Core: Run Wiimote::Initialize before HW::Init to avoid crash #9086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash on Android (probably nogui too?) caused by PR 8985: std::__ndk1::__throw_out_of_range(char const*) stdexcept:265 std::__ndk1::__vector_base_common<true>::__throw_out_of_range() const vector:319 InputConfig::GetController(int) InputConfig.cpp:160 WiimoteCommon::GetHIDWiimoteSource(unsigned int) Wiimote.cpp:71 IOS::HLE::WiimoteDevice::WiimoteDevice(IOS::HLE::Device::BluetoothEmu*, int, std::__ndk1::array<unsigned char, 6ul>) WiimoteDevice.cpp:71 IOS::HLE::Device::BluetoothEmu::BluetoothEmu(IOS::HLE::Kernel&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) BTEmu.cpp:64 IOS::HLE::Kernel::AddStaticDevices() IOS.cpp:435 IOS::HLE::Init() IOS.cpp:837 Core::EmuThread(std::__ndk1::unique_ptr<BootParameters, std::__ndk1::default_delete<BootParameters> >, WindowSystemInfo) Core.cpp:442
jordan-woyak
approved these changes
Sep 15, 2020
|
Expecting me to test Android without being told was your first mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes a crash on Android (probably nogui too?) caused by PR #8985: