New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various GameINI updates #9093
Various GameINI updates #9093
Conversation
… Trainer: The Ultimate Fitness System
|
I confirmed a lot of these earlier this morning for Techjar. As long as the INIs are done right, lgtm. |
826a77b
to
71fb013
Compare
|
LGTM once those two things are addressed. There are still some unfixed game INI issues on the issue tracker, but I see no reason to block this PR because of that. |
71fb013
to
0079118
Compare
…Squadron III - Rebel Strike
…nt XFB" for Super Paper Mario
…de: Veronica X (PAL)
…Baseball 2005 Thanks to hthh for figuring out this dcache issue!
0079118
to
5fbf3d2
Compare
…ber 2003 This disc contains an F-Zero GX demo.
5fbf3d2
to
31083e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes can be addressed in a future pr, but I'm frankly put off by Github to do it myself. Please feel free to ignore, since the titles are clear enough as they are. The only one that really need to change, is the Pikmin one.
# HA9xxx - Super Mario Bros. (Brawl VC)should read# HA9xxx - Super Mario Bros. (Brawl Masterpiece)to use the official terminology# NAKE01, NAKP01 - Pokemon Snapshould have the "(VC)" suffix, since a new game was announced and it doesn't hurt to be explicit.# NALE01, NALJ01, NALP01 - Super Smash Bros. (Virtual Console)# NATJ01, NATP01, NATE01 - Mario Tennis (Virtual Console)this is merely for consistency, but one could shorten the instances of "(Virtual Console)" to "(VC)"# R9IE01 - PIKMIN1 for Wiishould say# R9IE01 - PIKMIN (Wii)# XAFJJ8 - Metal Gear (MSX)the title is unclear# XAFJJ8 - Metal Gear (MSX version) (VC)would be clearer as well as# XANJJ8 - Gradius 2 (MSX version) (VC)and# XAQJJ8 - Salamander (MSX version) (VC)# XAIJJ8 - Quarthdoes not specify the version, even though there are several eligible ports.# XAIJJ8 - Quarth (MSX version) (VC)is better
I would love to go through each ini file if necessary. I have this weird thing were I find such activities greatly satisfying
|
The titles listed in game INIs are pretty inconsistent in general (which doesn't actually lead to a lot of problems in practice since the title isn't actually used for anything). If we want to start caring about having correct titles in game INIs, we should probably start by doing a mass replace with titles from GameTDB.com or something similar. |
|
@JosJuice I agree, I also can look at every natural language sentence in the code (comments and user facing strings) to look for typos and punctuation errors. I'm not kidding when I say that I like doing it, it's just hard to find a place where they would even want me to. |
I've itemized each change (or set of changes) into separate commits, making it easier to see what all the specific changes are.
Here's the list of issue reports this addresses:
https://bugs.dolphin-emu.org/issues/7909
https://bugs.dolphin-emu.org/issues/11198
https://bugs.dolphin-emu.org/issues/11389
https://bugs.dolphin-emu.org/issues/10556
https://bugs.dolphin-emu.org/issues/11322
https://bugs.dolphin-emu.org/issues/10703
https://bugs.dolphin-emu.org/issues/11918
https://bugs.dolphin-emu.org/issues/11477
https://bugs.dolphin-emu.org/issues/11732
https://bugs.dolphin-emu.org/issues/12155
https://bugs.dolphin-emu.org/issues/6752
https://bugs.dolphin-emu.org/issues/12189
https://bugs.dolphin-emu.org/issues/12251
https://bugs.dolphin-emu.org/issues/12225
https://bugs.dolphin-emu.org/issues/12023