WiimoteReal: Only duplicate data reports when speaker data is enabled. #9098
+21
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything in this makes sense to me. I quickly tested Sonic and the Secret Rings and it seemed to be fine with Speaker Data off. Question? Does Bluetooth Passthrough get into sniff mode though? If it does, why is audio data so iffy still? |
Yes, "sniff" mode is set in Bluetooth Passthrough where Wii remote audio works flawlessly here. |
leoetlino
approved these changes
Oct 23, 2020
|
I've got a report of this causing severe input delay for the pointer and nothing else, oddly enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently, data reports of real remotes are repeated to trigger sending of speaker data.
This causes some games to fail at detecting motion gestures.
https://bugs.dolphin-emu.org/issues/10111
https://bugs.dolphin-emu.org/issues/12030
With this change if speaker data is disabled so is repeating of data reports.
This fixes gestures in these games so long as speaker data is disabled.
Another potential fix might be to interpolate accelerometer data in repeated reports but that is getting pretty hacky.
I think this is cleaner.