Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP/Top: Add SO_LINGER optname #9099

Merged
merged 1 commit into from Oct 19, 2020
Merged

IP/Top: Add SO_LINGER optname #9099

merged 1 commit into from Oct 19, 2020
+2 −0

Conversation

sepalani
Copy link
Contributor

@sepalani sepalani commented Sep 20, 2020 •
edited

This PRs adds the SO_LINGER optname and silents the following message SO_SETSOCKOPT: unknown optname 128.

Ready to be reviewed & merged.

EDIT: This PR fixes SO_LINGER flag not working on Parrot OS (Linux) as SO_LINGER was defined as 13 not 0x0080.

BhaaLseN
BhaaLseN approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to sys/socket.h, SO_LINGER is 0x0080 - so this checks out. Untested tho.

I did notice SO_ERROR is 0x1007 and not 0x1009, but thats probably out of scope here.

@sepalani
Copy link
Contributor Author

sepalani commented Oct 4, 2020 •
edited

@BhaaLseN It wouldn't surprise me that they didn't keep the original value for SO_ERROR or that for some systems it's defined as 0x1009 rather than 0x1007. I'll write an hardware test to confirm that and see what are the other missing values in another PR.

@lioncash lioncash merged commit c9b2fbb into dolphin-emu:master Oct 19, 2020
10 checks passed
@sepalani sepalani deleted the so-linger branch October 19, 2020 15:15
@sepalani sepalani mentioned this pull request Oct 31, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@sepalani @lioncash @BhaaLseN