Include-what-you-use suggested fixes. #91
Merged
+1,975
−471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detected by this change).
… detected by this change).
|
Now builds everywhere thanks to Lioncash's and flacs' fixes. Any objection to merging this branch? |
|
No objections. Looks great. Matthew Parlane
|
delroth
added a commit
that referenced
this pull request
Feb 23, 2014
Include-what-you-use suggested fixes.
delroth
added a commit
that referenced
this pull request
Feb 23, 2014
For some reason it passed builbot-try but didn't build after being merged to msater. Did not expect that, sorry :(
lioncash
pushed a commit
to lioncash/dolphin
that referenced
this pull request
Mar 3, 2014
For some reason it passed builbot-try but didn't build after being merged to msater. Did not expect that, sorry :(
Techjar
pushed a commit
to Techjar/dolphin
that referenced
this pull request
Jan 30, 2022
* Adding in morphball profiles. * Fixing bug where profile didn't load immediately when selecting the profile nor when saving the current profile. * One last change to remove leftover code. * Fixing coding standard issues. Moved morphball profile switch into a function in PrimeUtils to more consistent with Primehack, per PR request. * Adding support for the PrimeHack tab on the standard "Emulated Wiimote" controller GUI. * Quick rename to "Morphball Profile" on Metroid Wiimote controller just for uniformity with the standard Emulated Wiimote controller menu. * Updating support for Morphball Profile to work on all the Wii versions of Metroid Prime series. * Fixed bugs made when rushing... Yeah!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently only in Common/DiscIO/DolphinWX.
The basic idea is the following: most of our files before were getting their dependencies via transitive includes instead of directly including what they use/need. Using IWYU (an open source tool based on clang) I fixed most of that in these 3 directories.
On top of removing accidental and non-explicit dependencies (causing less rebuilds when you modify a .h), this also avoids over-including.
Doesn't build on Windows and OS X yet, PR mostly for initial feedback.