Android: seekbar.setMin requires API level 26

[Ebola16]

Apparently there's no good alternative before setMin was implemented for dealing with minimums less than 0.

[JosJuice]

Oh, indeed. Weird that it didn't exist before then, but good catch.

Could you add some clamping to SliderSetting.setSelectedValue (i.e. changing selection to Math.max(selection, getMin())) so that we don't write invalid values to the SYSCONF, preferably with a comment mentioning the API 26 problem? I can merge it after that.

[JosJuice]

On second thought, it's probably better to clamp when calling setSelectedValue here, so that the workaround for the issue is in the same part of the code as the issue:

dolphin/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java

Lines 417 to 421 in 86a3721

	IntSliderSetting sliderSetting = (IntSliderSetting) mClickedItem;
	if (sliderSetting.getSelectedValue(getSettings()) != mSeekbarProgress)
	mView.onSettingChanged();
	sliderSetting.setSelectedValue(getSettings(), mSeekbarProgress);

[Ebola16]

Like this? Since we're now clamping, I'm assuming it's cleaner to remove setMin completely.

[JosJuice]

Please keep calling setMin on API 26 and above. That way we can avoid subpar UX for users who are on API 26 or higher. Being able to set the slider to 0 but then having it revert to 1 isn't very clean from the user's perspective.

Alternatively... Maybe the solution which would be the cleanest for all users (but would require slightly more code) would be to not call setMin at all, and instead call getMax with item.getMax() - item.getMin(), and adjust for the discrepancy in onSliderClick and onProgressChanged so that the text shown on the screen and the value stored to the settings go from item.getMin() to item.getMax().

[Ebola16]

The problem with adjusting for item.getMin in onProgressChanged is that multiple presses of the slider dialog without changing the value will apply the adjustment multiple times. Is the current state of this PR acceptable instead?

[JosJuice]

I'll merge this as-is so that we'll have it fixed before tagging the next beta. I might make another PR later to refine the logic.