Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ini configuration files for Phantasy Star Online Episode I&II Trial Edition and Episode III Trial Edition #9113

Merged
merged 5 commits into from Oct 20, 2020

Conversation

ShiftaDeband
Copy link
Contributor

This pull request adds two new .ini configuration files for game IDs DPSJ8P (Phantasy Star Online Episode I&II Trial Edition) and DPOJ8P (Phantasy Star Online Episode III C.A.R.D. Revolution Trial Edition).

To summarize, both games require the same SafeTextureCacheColorSamples = 512 configuration to render text more properly. PSO Episode III appears to have or had issues with Immediate XFB, so it is set to ImmediateXFBEnable = False.

In addition, the PSO Ep. I&II Trial Edition requires a modem to be present. Since the modem was the only option at the time, the BBA will not be recognized. This requires either a 32-bit patch (80194F40 4182002C, thank you to evilhamwizard) or an Action Replay code (04194F40 4182002C, thank you Sappharad) to bypass the initial screen as outlined on the wiki page.

Thank you for your consideration.

@Rumi-Larry
Copy link

Rumi-Larry commented Sep 26, 2020

Since there has been fixes to EFB emulation recently, it would be better if someone could confirm if InmediateXFB is still broken on this game, so it isn't turned off unecessarilly.

@JosJuice
Copy link
Member

JosJuice commented Sep 26, 2020

The fixes to EFB readback shouldn't affect the behavior of issues related to Immediately Present XFB.

@ShiftaDeband
Copy link
Contributor Author

You bet. I’ll test and get back to you all within the next 24 hours.

@ShiftaDeband
Copy link
Contributor Author

It appears that this game used to have issues rendering some of the FMVs without that option. After testing, it appears that it may not be needed for this game now.

Removed and requesting another review.

Thank you!

@leoetlino leoetlino requested a review from JMC47 October 20, 2020 00:00
@leoetlino
Copy link
Member

[15:20:03] leoetlino: JMC47: does #9113 look fine to you?
[15:32:48] JMC47: leoetlino: looks good to me

@leoetlino leoetlino merged commit 47059f6 into dolphin-emu:master Oct 20, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants