Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals: Update MoltenVK to v1.1 #9126

Merged
merged 1 commit into from Oct 3, 2020
Merged

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Oct 2, 2020

Needs testing as my mac environment is not usable at the moment.

@spotlightishere
Copy link
Contributor

Is it possible that this could be built to target both x86_64 and arm64? Upstream supports both configurations as of v1.1, and it might be beneficial within one PR now.

Otherwise - works as it should under Big Sur!

@stenzek
Copy link
Contributor Author

stenzek commented Oct 2, 2020

Thanks for checking.

I don't see why not, but the main dolphin application would have to support ARM too. And that would require Qt from brew to support it, and I'm not sure if that does yet?

@spotlightishere
Copy link
Contributor

Sadly not, quite yet - you can apply patches listed in their upstream tracking bug to have a single architecture build function and then lipo together x86_64 normal builds, but that is fairly manual at the moment. Dolphin itself works with some edits which I haven't quite yet finalized to draft a PR.

Mostly I figured I'd mention here so another update doesn't need to take place later down the line :)

@stenzek
Copy link
Contributor Author

stenzek commented Oct 2, 2020

Will keep it in mind, but to keep the download sizes smaller I'll probably just add a separate dylib later on rather than going for the merged library now. Unless of course dolphin itself is a fat binary, not sure what we're going to do there yet.

@stenzek stenzek merged commit 0fe6081 into dolphin-emu:master Oct 3, 2020
10 checks passed
@stenzek stenzek deleted the moltenvk-1.1 branch October 3, 2020 01:39
@gilcel
Copy link

gilcel commented Oct 3, 2020

Tested with some GC & Wii-games and it works great on macOS Mojave 10.14.6 (Mac mini Late 2012 with Intel HD Graphics 4000, not the fastest setup). thanks!

@pizuz
Copy link

pizuz commented Oct 4, 2020

I'm seeing a nice performance boost, here. Besides, GPU texture decoding, disabled in #8743 seems to be unbroken by the new release, from what I can tell. No more crashes, black textures or stuff loading on the second launch only in the games I tested (the screenshot was taken from the last build before #8743 with the dylib replaced, the vanilla build crashes as expected).

Screenshot 2020-10-04 at 17 06 40

@KevinVitale
Copy link

KevinVitale commented Oct 4, 2020

Compiled Dolphin for the first time to try out Vulkan on my macOS. Seems stable overall, with some nice performance boost. Some specific performance dips on NHL HItz 20-03 are noticeable; mostly 60fps solid, but when players have the "smoke" effect, performance drops by nearly half (with lots of audio stutter) during replays & face-offs.

Playing on:
2017 MacBook Pro
10.15.7 (19H2)
3.1 GHz Quad-Core Intel Core i7
16GB 2133 MHz LPDDR3
Radeon Pro 560 4 GB


Screen Shot 2020-10-04 at 4 43 26 PM

@JMC47
Copy link
Contributor

JMC47 commented Oct 4, 2020

Smoke effects result in a lot of blending, which is probably hard on MoltenVK. It's normal for those to cause slowdown in non-optimal setups or weaker computers.

@Rumi-Larry
Copy link

I'm seeing a nice performance boost, here. Besides, GPU texture decoding, disabled in #8743 seems to be unbroken by the new release, from what I can tell. No more crashes, black textures or stuff loading on the second launch only in the games I tested (the screenshot was taken from the last build before #8743 with the dylib replaced, the vanilla build crashes as expected).

In that case, that change can be reverted can't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants