Core: Break movie header validity checking into a function #913
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,6 +103,14 @@ static void EnsureTmpInputSize(size_t bound) | |||
| tmpInput = newTmpInput; | |||
| } | |||
|
|
|||
| static bool IsInvalidMovieHeader(u8 magic[4]) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@delroth done |
|
Except you didn't change the function body, so this now does the opposite of what it should do. |
|
woops |
|
Ok everything should be good now. |
delroth
added a commit
that referenced
this pull request
Aug 31, 2014
Core: Break movie header validity checking into a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.