New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: add reverse landscape to screen orientation settings #9139
Android: add reverse landscape to screen orientation settings #9139
Conversation
|
I specifically made it default to a mode that does not take the sensor data into account in order to avoid accidentally triggering orientation changes when using motion controls. I would not mind adding |
|
Uhm yeah I definitely missed that. Another thing we can do is add SCREEN_ORIENTATION_REVERSE_LANDSCAPE as an option and keep LANDSCAPE as default, so in both cases they don't interfere with motion controls. |
|
That sounds good to me. |
|
Ok what I haven't considered now is if motion controls are expecting a reverse landscape setting. I will have to test that. |
|
Motion controls should be working correctly regardless of orientation, but feel free to check to make sure. |
|
Tested all combinations, working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you squash the commits into one and update the pull request title.
|
Should be good to go. |
Until now, when screen orientation is set to Landscape, the emulation activity will be fixed on a 90 degrees rotated position.
This pull request aims at allowing 90 and 270 degrees landscape rotations, based on sensor data (independently of user android settings).
Controllers like the Gamesir X2, which have a USB Type-C port on the left will force the phone to a 270 degrees rotated state, so this is useful for those users (like me).