Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable GPU Texture Decoding under MoltenVK #9141

Merged
merged 2 commits into from Oct 29, 2020

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Oct 8, 2020

Apparently working again with the MoltenVK update in #9126. This supersedes #9140 by not undoing the moving of the closing bracket. @stenzek should we remove the DriverDetails bug itself as well, or keep it around in case it's needed again?

Would like to see some test cases just to be sure it's working properly.

@MayImilae
Copy link
Contributor

MayImilae commented Oct 8, 2020

Tested on my macbook. GPU Texture Decoding works, and this PR reveals it as it should. And MoltenVK is still glitchy (not GPU texture decoding's fault). Everything is as expected!

Game Tested
Sonic Colors (NTSC)

System Specs
MacBook Pro 13in mid-2018 with Touch Bar
macOS 10.15.6
Core i7-8559U @ 4.5ghz
Intel Iris Plus Graphics 655
16GB 2133MHz LPDDR3

@stenzek
Copy link
Contributor

stenzek commented Oct 8, 2020

Probably just drop the bug. I think the only other place it would be relevant would be drivers without sufficient texel buffer space, and if I remember correctly we test the size there and disable it accordingly anyway.

@pizuz
Copy link

pizuz commented Oct 8, 2020

Working without problems on all the games I tested so far (Wind Waker, Twilight Princess, Mario Kart Double Dash, Paper Mario TTYD and Super Mario Galaxy).

System: Late 2012 iMac with nVidia GeForce GT 750M

@MayImilae
Copy link
Contributor

Can we get this one merged? It's already tested and this isn't a very big change at all.

@JMC47 JMC47 merged commit 6a3a71c into dolphin-emu:master Oct 29, 2020
10 checks passed
@theOG1

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants