AudioStretcher: Keep default parameters. #9145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Citra's audio stretching does sound a lot better than Dolphin's, if I'm being honest. I'll test this when I get a chance. |
|
sgtm |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A user said Citra's sound stretching sounding much better than ours.
Looking at their code about the only difference was some explicit settings in Dolphin.
https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/AudioCommon/AudioStretcher.cpp
https://github.com/citra-emu/citra/blob/master/src/audio_core/time_stretch.cpp
It looks like the default "sequence" and "seek window" adjust automatically with the tempo, maybe?
https://www.surina.net/soundtouch/README.html
The user said this change improved audio stretching.
I don't know if I can tell a difference one way or the other.
Please test.