Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Allow disabling cover downloading #9146

Merged
merged 3 commits into from Oct 20, 2020
Merged

Android: Allow disabling cover downloading #9146

merged 3 commits into from Oct 20, 2020
+193 −39

Conversation

JosJuice
Copy link
Member

In case someone wants to be very careful with how much bandwidth they use or with what data GameTDB.com collects on you. This is already an option in DolphinQt (though in DolphinQt it will switch entirely from using covers to banners when turned off).

@JosJuice JosJuice force-pushed the android-disable-cover-download branch from 771cd6b to 8781e72 Compare October 11, 2020 19:02
@JosJuice JosJuice mentioned this pull request Oct 11, 2020
Closed
3 tasks
Ebola16
Ebola16 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably no need to split off the first commit since this PR seems pretty straightforward.

@Ebola16
Copy link
Member

Ebola16 commented Oct 14, 2020 •
edited

At some point InputOverlay will need access to Settings so settings can be set there instead of using SharedPreferences. Do you think that should be accomplished by using the method you removed from EmulationActivity in this PR or something more global?

@JosJuice
Copy link
Member Author

I believe it would make most sense to re-add the method I removed from EmulationActivity. (Unless we put the Settings object directly in InputOverlay?)

@Ebola16
Copy link
Member

Ebola16 commented Oct 14, 2020 •
edited

I think I'll go with the method removed in this PR then. I just wanted to make sure I wouldn't conflict with your planned changes.
One other question, does mSettings.close need to be called in onDestroy if used in InputOverlay? I wouldn't expect mSettings to survive after InputOverlay's destruction but I might be misunderstanding something.

@Ebola16
Copy link
Member

Ebola16 commented Oct 14, 2020

Oh mSettings.close is called in EmulationActivity, never mind.

Ebola16
Ebola16 suggested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While working on the SharedPreferences to INI PRs, I found that SharedPreferences are set in EmulationActivity.toggleControls. When converted to INI settings, I'll need access to Settings to set those values. Please revert the change that removes mSettings in EmulationActivity.

@JosJuice JosJuice force-pushed the android-disable-cover-download branch from 8781e72 to 7d26423 Compare October 14, 2020 21:04
@JosJuice
Copy link
Member Author

Done.

Ebola16
Ebola16 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self to update #8894 and #9152 after this PR is merged.

@JosJuice
Copy link
Member Author

JosJuice commented Oct 14, 2020 •
edited

I'll need to update PR #9148 too. (Or this PR, if that PR gets merged first.)

EDIT: Done.

@JosJuice
Android: Allow reading global settings without a Settings object
195b551 
This makes things more convenient for code that just
wants to read the current value of a setting.
@JosJuice
Android: Allow disabling cover downloading
5e70dda 
In case someone wants to be very careful with how much bandwidth
they use or with what data GameTDB.com collects on you.
This is already an option in DolphinQt (though in DolphinQt it
will switch entirely from using covers to banners when turned off).
@JosJuice
Android: Refetch game metadata after returning from settings
6380c65
@JosJuice JosJuice force-pushed the android-disable-cover-download branch from 7d26423 to 6380c65 Compare October 19, 2020 18:35
@JosJuice JosJuice mentioned this pull request Oct 20, 2020
Merged
@leoetlino leoetlino merged commit 2e86e1a into dolphin-emu:master Oct 20, 2020
10 checks passed
@JosJuice JosJuice deleted the android-disable-cover-download branch October 20, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

@Ebola16 Ebola16 Ebola16 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @Ebola16 @leoetlino