Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix setting read during play with local game layer active #9148

Merged
merged 1 commit into from Oct 19, 2020

Conversation

JosJuice
Copy link
Member

During emulation, when LocalGame has a value but CurrentRun doesn't, we want to read from LocalGame, not CurrentRun. This change exposes a LAYER_ACTIVE option that handles this correctly.

During emulation, when LocalGame has a value but CurrentRun
doesn't, we want to read from LocalGame, not CurrentRun. This
change exposes a LAYER_ACTIVE option that handles this correctly.
@JosJuice
Copy link
Member Author

To clarify what the bug is, here are reproduction steps:

  1. Turn on Show FPS in the game-specific settings for some game.
  2. Start that game.
  3. Open the graphics settings. Observe that Show FPS shows up as disabled, even though the FPS actually is being displayed.

Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to get more familiar with the new config system to understand how changes can potentially go wrong but this makes sense to me.

@leoetlino leoetlino merged commit a209410 into dolphin-emu:master Oct 19, 2020
10 checks passed
@JosJuice JosJuice deleted the android-active-layer branch October 19, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants