Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Convert SharedPreferences to INI Settings (simple cases) #9152

Merged
merged 3 commits into from Oct 21, 2020

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Oct 16, 2020

Part of https://bugs.dolphin-emu.org/issues/10957

This will allow some settings to be retained across Dolphin builds. Other PRs will handle more involved SharedPreferences changes.

I'm aware that globally getting settings will come out soon but I figured I should submit this for review before I proceed further.

Note: Android: wiiController is implemented in #8894 and orientation is implemented in #9089.

@Ebola16
Copy link
Member Author

Ebola16 commented Oct 20, 2020

Feel free to review / merge this at any time. I'll occasionally work on the more complicated INI conversions and if I figure them out I'll commit them here, like the latest commit.

@JosJuice
Copy link
Member

I'd much rather prefer to not have the number of settings migrated by this PR increase, otherwise this PR becomes harder for me to review the more time passes, which is kind of the opposite of how it usually works. I would suggest that you remove the ISOPaths commit from this PR so that I can approve it sooner.

@Ebola16
Copy link
Member Author

Ebola16 commented Oct 20, 2020

That's fair, most PR merges I've done are to avoid conflicts with my other PRs.

Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably call mSettings.saveSettings here, so that settings will persist the next time the user runs the app:

if (!isChangingConfigurations())
{
mEmulationFragment.saveTemporaryState();
}

@leoetlino leoetlino merged commit f265c41 into dolphin-emu:master Oct 21, 2020
10 checks passed
@Ebola16 Ebola16 deleted the SP1 branch October 21, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants