New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Convert SharedPreferences to INI Settings (simple cases) #9152
Conversation
3761f21
to
8811f65
Compare
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Show resolved
Hide resolved
...roid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java
Show resolved
Hide resolved
1ffe36f
to
89c4e84
Compare
e94fad4
to
b1cafe6
Compare
|
Feel free to review / merge this at any time. I'll occasionally work on the more complicated INI conversions and if I figure them out I'll commit them here, like the latest commit. |
|
I'd much rather prefer to not have the number of settings migrated by this PR increase, otherwise this PR becomes harder for me to review the more time passes, which is kind of the opposite of how it usually works. I would suggest that you remove the ISOPaths commit from this PR so that I can approve it sooner. |
|
That's fair, most PR merges I've done are to avoid conflicts with my other PRs. |
560c3d6
to
7789864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably call mSettings.saveSettings here, so that settings will persist the next time the user runs the app:
dolphin/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Lines 325 to 328 in 5a939cc
| if (!isChangingConfigurations()) | |
| { | |
| mEmulationFragment.saveTemporaryState(); | |
| } |
Part of https://bugs.dolphin-emu.org/issues/10957
This will allow some settings to be retained across Dolphin builds. Other PRs will handle more involved
SharedPreferenceschanges.I'm aware that globally getting settings will come out soon but I figured I should submit this for review before I proceed further.
Note: Android: wiiController is implemented in #8894 and orientation is implemented in #9089.