Android: ConfirmRunnable to RunRunnable with optional confirmation #9154
+110
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ebola16
force-pushed
the
RR
branch
2 times, most recently
from
c0fb051
to
085d3d3
Compare
|
And I changed the dialog buttons to OK / Cancel to make them more applicable for future uses. |
JosJuice
reviewed
Oct 18, 2020
...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/view/RunRunnable.java
Outdated
Show resolved
Hide resolved
...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/view/RunRunnable.java
Outdated
Show resolved
Hide resolved
JosJuice
approved these changes
Oct 18, 2020
|
I'm guessing git doesn't consider a file renamed if things other than renaming occur? That's the most striking difference between the files in question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some future runnable calls may not need confirmation.