Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/XInput2: Fix keys being stuck pressed on focus loss. #9160

Merged
merged 1 commit into from Oct 21, 2020

Conversation

jordan-woyak
Copy link
Member

This fixes the issue of "Alt" being stuck after an Alt+Tab away from Dolphin.

Keyboard state is now cleared on XI_FocusOut.

At least on my system, cycling Alt-Tab and refocusing Dolphin does not capture XI_FocusOut or XI_KeyRelease.
I've added a workaround with XQueryKeymap.

Other minor cleanups.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but the logic looks sane to me.

@leoetlino leoetlino merged commit 97de366 into dolphin-emu:master Oct 21, 2020
10 checks passed
@jordan-woyak jordan-woyak deleted the xinput2-stuck-keys branch December 30, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants