Replace stateful rotational matrices with quaternions. #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Oct 19, 2020
jordan-woyak
force-pushed
the
quaternion
branch
from
2775be3
to
28cc6a8
Compare
jordan-woyak
force-pushed
the
quaternion
branch
from
28cc6a8
to
71a500a
Compare
jordan-woyak
force-pushed
the
quaternion
branch
from
71a500a
to
907fdd2
Compare
|
Yay, a much needed addition. Excited to see this. I'll likely update the freelook camera controllers once this is merged to use normalized quaternions. |
lioncash
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an attempt to fix: https://bugs.dolphin-emu.org/issues/12077
Wii remote orientations were maintained as
Matrix33.We never made any attempt to normalize these and floating point inaccuracies will eventually make them invalid rotational matrices.
Orientations now use quaternions and are normalized.