Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataReader: Make use of if constexpr where applicable #9168

Merged
merged 1 commit into from Oct 20, 2020
Merged

DataReader: Make use of if constexpr where applicable #9168

merged 1 commit into from Oct 20, 2020
+2 −2

Conversation

lioncash
Copy link
Member

We can make use of if constexpr for cases where booleans will always statically be known at compile-time.

@lioncash
DataReader: Make use of if constexpr where applicable
7bc2bbc 
We can make use of if constexpr for cases where booleans will always
statically be known at compile-time.
leoetlino
leoetlino approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I believe this also fixes a possible MSVC warning.

@leoetlino leoetlino merged commit ce59b02 into dolphin-emu:master Oct 20, 2020
10 checks passed
@lioncash lioncash deleted the ifconst branch October 20, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@lioncash @leoetlino