Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputCommon: Rename class InputPlugin to InputConfig #917

Merged
merged 1 commit into from Sep 1, 2014

Conversation

lioncash
Copy link
Member

This name is way back from the plugin era.

@@ -15,20 +15,20 @@
namespace Pad
{

static InputPlugin g_plugin("GCPadNew", _trans("Pad"), "GCPad");
InputPlugin *GetPlugin()
static InputConfig g_config("GCPadNew", _trans("Pad"), "GCPad");

This comment was marked as off-topic.

delroth added a commit that referenced this pull request Sep 1, 2014
InputCommon: Rename class InputPlugin to InputConfig
@delroth delroth merged commit 24b5ce2 into dolphin-emu:master Sep 1, 2014
@Icekhaos
Copy link

Icekhaos commented Sep 2, 2014

Hunting down old stuff I see. Bloody awesome job, guys.

@lioncash lioncash deleted the input branch September 2, 2014 16:43
@lioncash
Copy link
Member Author

lioncash commented Sep 2, 2014

Thanks :)

@Icekhaos
Copy link

Icekhaos commented Sep 2, 2014

I'd love to see you guys actively hunt pre-2.0 issues down like the prevention of apocalypse was dependent on it. Old quirks out means a stable platform for groundwork.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 2, 2014

@Icekhaos This is not the correct place to ask for things. If you have a specific bug, try the issue tracker. I see no entry for "prevention of apocalypse": https://code.google.com/p/dolphin-emu/issues/list?can=2&q=prevention+of+apocalypse

... also, a quick web search doesn't even show that this is the title of a game. So, no idea what you're talking about. File a issue.

@Icekhaos
Copy link

Icekhaos commented Sep 3, 2014

Just saying that I like seeing old issues getting fixed. Saying you guys should keep these old bugs out, as if preventing apocalypse depended on fixing said bugs.

Only in, what? 2014 have I seen old ass bugs killed, some from plugin era, and one from as early as Dolphin wasn't even GPL.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

Yea uh, I understood the phrase after posting...oops :)

@Icekhaos
Copy link

Icekhaos commented Sep 3, 2014

I should donate your next coffee cup. Maybe also a round of beer for you and lioncash.

Ontopic: Where's the build tools? I might get myself mentored in C by contributions.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

What do you mean by build tools? There are build instructions on the github wiki.

@Icekhaos
Copy link

Icekhaos commented Sep 3, 2014

Thank you. Was looking to build on Windows. In particular, I want to see if I can extend the widescreen hack to kill off occlusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants