ARDecrypt: Resolve seedtable at compile-time #9175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can boot the formation of the table off to the compiler at compile-time, rather than building the table at run-time.
jordan-woyak
approved these changes
Oct 21, 2020
leoetlino
approved these changes
Oct 21, 2020
| seeds[j] = tmp3; | ||
| j -= 2; | ||
| } | ||
| u32 tmp3 = seeds[i]; |
There was a problem hiding this comment.
Possible followup PR: use std::swap to get rid of tmp3?
There was a problem hiding this comment.
Unfortunately std::swap isn't constexpr in C++17, so this can't be done. This would be a candidate whenever we move to C++20 though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We can boot the formation of the table off to the compiler at compile-time, rather than building the table at run-time.