VideoCommon: Get rid of the global g_available_video_backends #9179
+41
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Oct 21, 2020
Replace it with a function-local static that is initialized on first use. This gets rid of a global variable and removes the need for manual initialization in UICommon. This commit also replaces the weird find_if that looks for a non-null unique_ptr with a simple "is vector empty" check considering that none of the pointers can be null by construction.
Now we can just call GetDefaultVideoBackend to get the default backend and get its name by calling GetName.
leoetlino
force-pushed
the
available-video-backends
branch
from
f56ec9e
to
d08b808
Compare
iwubcode
reviewed
Oct 21, 2020
| { | ||
| // OGL > D3D11 > D3D12 > Vulkan > SW > Null | ||
| static auto s_available_backends = [] { |
There was a problem hiding this comment.
Why do you need the lambda?
There was a problem hiding this comment.
The lambda is just a convenient way to make sure the initialization code only runs once.
There was a problem hiding this comment.
Ah right, it's static, that makes sense. Thanks!
iwubcode
approved these changes
Oct 22, 2020
JosJuice
approved these changes
Oct 23, 2020
|
Vulkan has vanished from the graphics menu after this |
|
Oh, that must be a regression from #7395... I'll investigate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replace it with a function-local static that is initialized on first
use. This gets rid of a global variable and removes the need for
manual initialization in UICommon.
This commit also replaces the weird find_if that looks for a non-null
unique_ptr with a simple "is vector empty" check considering that
none of the pointers can be null by construction.
Also simplifies GetDefaultBackendName: now we can just call
GetDefaultVideoBackend to get the default backend
and get its name by calling GetName.