Common: Migrate logging to fmt #9187
Merged
+153
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continues the migration of our code over to the fmt logger.
BhaaLseN
approved these changes
Oct 23, 2020
| @@ -221,8 +221,8 @@ HttpRequest::Response HttpRequest::Impl::Fetch(const std::string& url, Method me | |||
| curl_easy_getinfo(m_curl.get(), CURLINFO_RESPONSE_CODE, &response_code); | |||
| if (response_code != 200) | |||
| { | |||
| ERROR_LOG(COMMON, "Failed to %s %s: server replied with code %li and body\n\x1b[0m%.*s", type, | |||
| url.c_str(), response_code, static_cast<int>(buffer.size()), buffer.data()); | |||
| ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {} and body\n\x1b[0m{:.{}}", | |||
There was a problem hiding this comment.
Just wondering, why does this one have an ANSI reset code in it?
There was a problem hiding this comment.
I legitimately don't know
There was a problem hiding this comment.
For the record:
[23:44:56] <@Bh44L> leoetlino: do you remember why that log message in 9187 has an ANSI reset code in it?
[23:45:16] <@Bh44L> came from 5599
[23:47:05] <@leoetlino> uh, I think it was to make the response body stand out more in stderr output
[23:48:01] <@leoetlino> it's not strictly required, but it makes it easier to see where the body begins and ends when you have several ERROR_LOGs in a row
[23:56:40] <@Bh44L> oh, right, log goes to console as well
[23:56:42] <@Bh44L> ¯\_(ツ)_/¯
leoetlino
approved these changes
Oct 26, 2020
JosJuice
reviewed
Oct 26, 2020
| #ifdef _WIN32 | ||
| if (CopyFile(UTF8ToTStr(source_path).c_str(), UTF8ToTStr(destination_path).c_str(), FALSE)) | ||
| return true; | ||
|
|
||
| ERROR_LOG(COMMON, "Copy: failed %s --> %s: %s", source_path.c_str(), destination_path.c_str(), | ||
| GetLastErrorString().c_str()); | ||
| ERROR_LOG_FMT(COMMON, "Copy: failed %s --> %s: %s", source_path, destination_path, |
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Oct 26, 2020
Fixes a recent regression: dolphin-emu#9187 (comment)
Minty-Meeo
pushed a commit
to Minty-Meeo/dolphin
that referenced
this pull request
Mar 17, 2021
Fixes a recent regression: dolphin-emu#9187 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Continues the migration of our code over to the fmt logger.