IP/Top: Add Android network interface #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepalani
force-pushed
the
net-interface
branch
2 times, most recently
from
bd4eec1
to
beb7ae2
Compare
10 tasks
JosJuice
reviewed
Oct 24, 2020
|
I've never worked with anything network related so I'm probably not the best person to review this PR. Feel free to mention me if you need help with testing something Android network-related in the future though. |
sepalani
force-pushed
the
net-interface
branch
3 times, most recently
from
5e86215
to
aa079cb
Compare
JosJuice
reviewed
Oct 24, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/NetworkHelper.java
Outdated
Show resolved
Hide resolved
sepalani
force-pushed
the
net-interface
branch
from
aa079cb
to
f071e43
Compare
JosJuice
reviewed
Oct 25, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/NetworkHelper.java
Outdated
Show resolved
Hide resolved
sepalani
force-pushed
the
net-interface
branch
2 times, most recently
from
ae5fdd1
to
2ebec11
Compare
|
@JosJuice Done. I also added some missing null checks which prevents a crash when there is no active network. |
|
Could you add the Keep annotations like #9256 did? |
sepalani
force-pushed
the
net-interface
branch
from
2ebec11
to
20ebed5
Compare
|
@leoetlino Done. |
leoetlino
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds for (not so old) Android devices network interface support allowing to use network functions such as
bind. This PRs should work for Ethernet, Wi-Fi and maybe other connection.Ready to be reviewed.