UberShaderPixel: Migrate over to fmt #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
All the curlies seem to be doubled and in the right place (except for that one that feels like it should move to the previous WriteFmt); but at some point it seem to have gone off course - feel free to ignore those code-style-of-shader-code-inside-a-string remarks.
Completes the migration over to using the fmt-formatting WriteFmt function. The next PR will rename all usages of WriteFmt, while simultaneously getting rid of the old printf code.
|
Resolved all of them. |
|
Will merge by end of today/beginning of tomorrow if no other reviews are made by then |
|
Time is up, taking the plunge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Completes the migration over to using the fmt-formatting WriteFmt function. The next PR will rename all usages of WriteFmt, while simultaneously getting rid of the old printf code.