Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals: Update fmt to 7.1.0 #9199

Merged
merged 1 commit into from Oct 27, 2020
Merged

Externals: Update fmt to 7.1.0 #9199

merged 1 commit into from Oct 27, 2020

Conversation

lioncash
Copy link
Member

Updates fmt to the latest release from 6.1.2, keeping it up to date.

Involves interface improvements, alongside codegen improvements: See the release changelogs for more info.

@iwubcode
Copy link
Contributor

Nice! Have you tried enabling FMT_USE_FULL_CACHE_DRAGONBOX to see if it gives us any noticeable improvements and what kind of impact it has on the binary size?

@lioncash
Copy link
Member Author

Nope. I don't want to experiment with settings when upgrading the library. I'd like to update it first and keep it working in the predictable manner it always has, then start fiddling around with things.

@iwubcode
Copy link
Contributor

iwubcode commented Oct 27, 2020

Oh, I wasn't suggesting you include that in this PR, I just noticed it in the release notes and was curious if you had tried it. The notes were rather vague on what advantage it'd provide.

@lioncash
Copy link
Member Author

Oh yeah, no, I haven't played around with it at all yet. I'd probably look into how it gets enabled before doing that. Depending on how it gets built, it might be preferable to move off of the header-only configuration.

@leoetlino
Copy link
Member

find_package(fmt 6.0)

This should probably be modified to require version 7 so that the build doesn't fail when we start using any of the new features -- CI doesn't use the system fmt so such a build issue would be easily missed.

Updates fmt to the latest release from 6.1.2
@lioncash
Copy link
Member Author

Done

@leoetlino leoetlino merged commit 52d8b51 into dolphin-emu:master Oct 27, 2020
10 checks passed
@lioncash lioncash deleted the fmt branch October 27, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants