Logic & UI for "Virtual Notches"

[nick-michael]

This is a feature that I wanted in Dolphin for quite some time now. It should make playing games like Super Monkey Ball feel a bit closer to using a GC controller when using a controller without an Octagonal gate (e.g. Xbox, PS4, Steam e.t.c).

Adds an option in the controller config to set the size of the virtual notches. These virtual notches add a sticky behaviour that will snap the controller to the different axis.

Disclaimer:
I've never written C++ before (besides Hello World about 10 years ago) so I'm completely open to suggestions for improvements. I was unable to get the linter running locally but I think Visual Studio was enforcing code styling while developing so I'm hoping it's already formatted correctly.

[nick-michael]

@lioncash Cheers for the review! Please check my most recent changes and mark as resolved if all is fine, otherwise let me know what I got wrong and I'll happily take another look 👍

[lioncash]

Only a few minor nits, otherwise the changes in response to the suggestions look pretty good!

[JMC47]

I do believe something like this would be very helpful in games that use notches. It's one of the reasons I use original GameCube controllers via adapter for most games.

[jordan-woyak]

Super neat feature. I just had a few suggestions.
Your code was not too bad for being new to C++.
The main thing was ApplyVirtualNotches being overly complicated.

[nick-michael]

NULL isn't a special value and isn't doing what you think it is. You're basically just writing 0.0 here.
I don't know why you changed this. Always assigning angle in Rehape was fine.

Ahh I left that in from when I was making additional changes to the dist value that should only be applied when inside a virtual notch. I removed that code so this can also be reverted to your original suggestion

[jordan-woyak]

After fixing the lint issues and squashing the commits this looks good to me.