Simplify Arm64GPRCache::Flush #9213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`flush = cond ? flush : true` makes little sense when `flush` is always true at that point.
degasus
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
I've tried to analyze why there is actually this code. I think this was from the very old days (2014) when we tried to speed up interpreter fallbacks. So this was missed on a cleanup. And indeed, as we mostly use Flush for branching, there is no point in keeping any registers dirty.
lioncash
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
flush = cond ? flush : truemakes little sense whenflushis always true at that point.