Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top: Set port when connecting a socket to find the default interface #9214

Merged
merged 1 commit into from Nov 2, 2020
Merged

Top: Set port when connecting a socket to find the default interface #9214

merged 1 commit into from Nov 2, 2020
+3 −1

Conversation

OatmealDome
Copy link
Member

This fixes an issue that was found in #8758. Previously, the call to connect in GetSystemDefaultInterface would fail with EADDRNOTAVAIL on macOS. If we set sin_port, the call will succeed.

Tested on macOS 11 Big Sur beta 10.

cc @sepalani

BhaaLseN
BhaaLseN approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sensible change; untested though.

sepalani
sepalani reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me.

Source/Core/Core/IOS/Network/IP/Top.cpp Outdated Show resolved Hide resolved
@sepalani sepalani mentioned this pull request Nov 2, 2020
Merged
10 tasks
leoetlino
leoetlino approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sounds sane.

@leoetlino leoetlino merged commit cbaf8f8 into dolphin-emu:master Nov 2, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepalani sepalani sepalani left review comments

@BhaaLseN BhaaLseN BhaaLseN approved these changes

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@OatmealDome @BhaaLseN @leoetlino @sepalani