Top: Set port when connecting a socket to find the default interface #9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Nov 2, 2020
10 tasks
OatmealDome
force-pushed
the
macos-bind
branch
from
81483ed
to
dd688f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes an issue that was found in #8758. Previously, the call to
connectinGetSystemDefaultInterfacewould fail withEADDRNOTAVAILon macOS. If we setsin_port, the call will succeed.Tested on macOS 11 Big Sur beta 10.
cc @sepalani