Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Suppress warnings in EmulationActivity #9223

Merged
merged 1 commit into from Nov 6, 2020
Merged

Android: Suppress warnings in EmulationActivity #9223

merged 1 commit into from Nov 6, 2020
+33 −31

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Nov 5, 2020

  • Instead of adding every case in the IntDef, it'd probably be better to suppress the SwitchIntDef warnings.
  • Returning nothing instead of breaking after each switch case seems silly. Android Studio complains that the final return was also unnecessary.

@JosJuice JosJuice merged commit 2acd3ab into dolphin-emu:master Nov 6, 2020
10 checks passed
@Ebola16 Ebola16 deleted the D branch November 6, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Ebola16 @JosJuice