Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Fix jobject/jclass warnings #9228

Merged
merged 2 commits into from Nov 9, 2020
Merged

Android: Fix jobject/jclass warnings #9228

merged 2 commits into from Nov 9, 2020
+82 −110

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Nov 6, 2020

Static methods use jclass, and non-static methods use jobject.

Ebola16
Ebola16 reviewed Nov 7, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Android Studio wants jclass obj for Java_org_dolphinemu_dolphinemu_NativeLibrary_onGamePadMoveEvent
  • Should we suppress the unused local variable warnings for MainAndroid.cpp? There's a lot of them.

@JosJuice
Copy link
Member Author

JosJuice commented Nov 7, 2020

I've fixed onGamePadMoveEvent. Not sure about the unused local variable warnings.

@Ebola16
Copy link
Member

Ebola16 commented Nov 7, 2020

I'd like something to be done about the large amounts of unused obj warnings if not suppression.

@JosJuice
Copy link
Member Author

JosJuice commented Nov 7, 2020

The latest commit should address it.

Ebola16
Ebola16 approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too.

@lioncash lioncash merged commit 418f9fa into dolphin-emu:master Nov 9, 2020
10 checks passed
@JosJuice JosJuice deleted the android-jclass branch November 9, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@Ebola16 Ebola16 Ebola16 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @Ebola16 @lioncash