Android: Handle failed boots correctly #9229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
android-emulationactivity-finish
branch
from
5672d5b
to
1a1df9b
Compare
Ebola16
approved these changes
Nov 7, 2020
lioncash
approved these changes
Nov 9, 2020
|
Feel free to merge once the conflict is resolved. |
This makes EmulationActivity automatically close if booting fails, and lets us get rid of s_emulation_end_event.
Time for yet another new iteration of working around the "surface destruction during boot" problem... This time, the strategy is to use a mutex in MainAndroid.cpp.
The previous commit made this easy to reproduce when launching an invalid disc image with the phone rotated incorrectly.
This is already handled by SurfaceDestroyed. In the worst case, the extra code could even race with SurfaceDestroyed if they are triggered at the same time, but this is highly improbable.
JosJuice
force-pushed
the
android-emulationactivity-finish
branch
from
4cd00e7
to
8181a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If you try to boot an invalid file in master (for instance if you pick Open File and try to open a PNG file you renamed to .iso), Dolphin more or less locks up. This PR aims to make that scenario work correctly.