Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Call saveSettings in EmulationActivity.onStop #9230

Merged
merged 1 commit into from Nov 9, 2020
Merged

Android: Call saveSettings in EmulationActivity.onStop #9230

merged 1 commit into from Nov 9, 2020

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Nov 6, 2020

I didn't realize that onSaveInstanceState doesn't get called when finishing the activity.

@JosJuice
Android: Call saveSettings in EmulationActivity.onStop
a1a4d12 
I didn't realize that onSaveInstanceState doesn't get called
when finishing the activity.
@JosJuice JosJuice mentioned this pull request Nov 6, 2020
Open
Ebola16
Ebola16 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made this change in a WIP PR so LGTM.

@lioncash lioncash merged commit 9872640 into dolphin-emu:master Nov 9, 2020
10 checks passed
@JosJuice JosJuice deleted the android-savesettings-onstop branch November 9, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@Ebola16 Ebola16 Ebola16 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @lioncash @Ebola16