Fix updater not always cleaning up temp directory

[Dentomologist]

Updater was only deleting TempUpdate folder when an error occured.

[leoetlino]

Fwiw, the bug wasn't present in the initial implementation (07c1603):

  bool ok = PerformUpdate(todo, opts.install_base_path, opts.content_store_url, temp_dir);
  if (!ok)
    fprintf(log_fp, "Failed to apply the update.\n");

  CleanUpTempDir(temp_dir, todo);
  return !ok;
}

[ghost]

Thanks for the fix! It was getting annoying having to delete that manually from the macOS Application folder. Any chance that the updater log could be changed to be saved with the rest of the logs instead of off by itself?

[Dentomologist]

Thanks for the fix! It was getting annoying having to delete that manually from the macOS Application folder. Any chance that the updater log could be changed to be saved with the rest of the logs instead of off by itself?

As it happens, I'm working on a separate PR that will include that.