Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a redundant i18n comment #9257

Merged
merged 1 commit into from Nov 17, 2020
Merged

Remove a redundant i18n comment #9257

merged 1 commit into from Nov 17, 2020
+1 −3

Conversation

JosJuice
Copy link
Member

No description provided.

BhaaLseN
BhaaLseN approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment removal seems ok, but I wonder: does that preceding i18n comment only apply to the next translation that follows (which is the degree symbol) or to the next line (which would be both of them)?

@JosJuice
Copy link
Member Author

Just the first one. I ran update-source-strings.sh to make sure.

@leoetlino leoetlino merged commit 8119318 into dolphin-emu:master Nov 17, 2020
10 checks passed
@JosJuice JosJuice deleted the redundant-i18n branch November 17, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN approved these changes

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @BhaaLseN @leoetlino