AudioCommon: Convert alerts over to fmt-based variants #9291
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Nov 27, 2020
Source/Core/AudioCommon/WaveFile.cpp
Outdated
| @@ -117,10 +117,10 @@ void WaveFileWriter::Write4(const char* ptr) | |||
| void WaveFileWriter::AddStereoSamplesBE(const short* sample_data, u32 count, int sample_rate) | |||
| { | |||
| if (!file) | |||
| PanicAlertT("WaveFileWriter - file not open."); | |||
| PanicAlertFmtT("WaveFileWriter - file not open."); | |||
There was a problem hiding this comment.
It feels a bit weird that this one is translated but the other one is not. Both messages seem like they don't make too much sense being either translated or shown to the user (since they likely can't do much about it anyways)
lioncash
force-pushed
the
alert-audio
branch
from
db89fd0
to
0ace9da
Compare
Continues the migration over to fmt Converts two panic alerts into error logs, since they aren't really things a user can do anything about.
lioncash
force-pushed
the
alert-audio
branch
from
0ace9da
to
56d233c
Compare
leoetlino
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Continues the migration over to fmt