Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rehabilitate Haiku support. #9323

Merged
merged 1 commit into from Jan 5, 2021
Merged

Conversation

waddlesplash
Copy link
Contributor

Much less invasive than the equivalent changes that were removed; it looks like things are a lot simpler than they were a few years ago when I last attempted this.

Unlike that attempt, this one is indeed able to boot games (after fixing a bug in our Qt port): http://0x0.st/iFif.png

@waddlesplash
Copy link
Contributor Author

Ha, seems I now have conflicts to resolve, thanks to #9309.

@waddlesplash
Copy link
Contributor Author

Should be all fixed.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to squash the commits :)

Source/Core/Common/GL/GLInterface/BGL.h Outdated Show resolved Hide resolved
Source/Core/Common/GL/GLInterface/BGL.cpp Outdated Show resolved Hide resolved
@waddlesplash
Copy link
Contributor Author

Done.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine and this doesn't require that many changes, so why not 🤷‍♂️

@leoetlino leoetlino merged commit eafb9de into dolphin-emu:master Jan 5, 2021
10 checks passed
@waddlesplash waddlesplash deleted the haiku branch January 5, 2021 15:25
@waddlesplash
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants