Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: Fix deprecated use of MidButton #9331

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Qt: Fix deprecated use of MidButton #9331

merged 2 commits into from
Dec 17, 2020

Conversation

leoetlino
Copy link
Member

MidButton has been deprecated since Qt 4.7. The replacement is
MiddleButton.

@leoetlino
Qt/Config: Remove unused includes
efdb620
@leoetlino
Qt: Fix deprecated use of MidButton
6018525 
MidButton has been deprecated since Qt 4.7. The replacement is
MiddleButton.
BhaaLseN
BhaaLseN approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a no-brainer. I'm assuming it is just a drop-in and should work the same way (untested).

@leoetlino
Copy link
Member Author

Yeah, MidButton is defined as

MidButton Q_DECL_ENUMERATOR_DEPRECATED_X("MidButton is deprecated. Use MiddleButton instead") = MiddleButton

@lioncash lioncash merged commit ac25256 into dolphin-emu:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoetlino @lioncash @BhaaLseN