Core: Fix various warnings #9332
Merged
+65
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to clear/memset the padding bytes, not just each member,
so using assignment or {} initialization is not an option.
To silence the warnings, cast the object pointer to u8* (which is not
undefined behavior) to make it explicit to the compiler that we want
to fill the object representation.
leoetlino
force-pushed
the
warning-fixes
branch
from
c3c26ae
to
0ad2f3d
Compare
BhaaLseN
approved these changes
Dec 16, 2020
| bool ConvertRGBAToRGBAndSavePNG(const std::string& path, const u8* input, u32 width, u32 height, | ||
| int stride = 0); | ||
|
|
||
| std::vector<u8> RGBAToRGB(const u8* input, u32 width, u32 height, int row_stride = 0); |
There was a problem hiding this comment.
I don't see this being called outside of Image.cpp (at least not in this diff), but it probably doesn't matter if we leave it for others (future) use.
There was a problem hiding this comment.
Yep, the idea was that it could come in handy in the future.
lioncash
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.