Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software: Always divide the texture coordinates by q. #9333

Merged
merged 1 commit into from Feb 13, 2021

Conversation

Pokechu22
Copy link
Contributor

Equivalent to da43f9a (#4197) for the software renderer. This should fix Fishing Resort (issue 3106 for HW renderer).

@Pokechu22
Copy link
Contributor Author

The large number of fifoci differences actually happened before (see #4197 (comment)), and most are the same as then (single-pixel differences). Here's an overview of the ones that have larger differences here or there:

Test caseThis PROld PRNotes
find-mii LinkLinkFixed issue in HW, not fixed in SW
fishing-resort-map LinkLinkFixed issue in both HW and SW
mario-sluggers-bar LinkLinkBrightness change in HW not found in SW
melee-lighting LinkLinkBrightness change in HW not found in SW
mii-channel LinkLinkBrightness change in HW not found in SW
rs2-zfreeze N/A LinkBrightness change, not diffable due to issue 11393
sf-assault-flashingLinkLinkBrightness change in HW not found in SW
soa-black LinkLinkBrightness change in HW not found in SW
ssbm-pointsize LinkLinkFixed issue in both HW and SW

@smurf3tte
Copy link
Contributor

Looks equivalent to me. 👀

Equivalent to da43f9a for the software renderer.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • aeon-charge-attack on sw-lin-mesa: diff
  • bk-tev on sw-lin-mesa: diff
  • burnout2-vehicletextures on sw-lin-mesa: diff
  • chibi-robo-fastdepth on sw-lin-mesa: diff
  • chibi-robo-zfighting on sw-lin-mesa: diff
  • custom-brawl-char on sw-lin-mesa: diff
  • dbz-depth on sw-lin-mesa: diff
  • djhero2-blend on sw-lin-mesa: diff
  • DKCR-Char on sw-lin-mesa: diff
  • DKCR-fast-depth on sw-lin-mesa: diff
  • ed-updated on sw-lin-mesa: diff
  • fifa-street on sw-lin-mesa: diff
  • find-mii on sw-lin-mesa: diff
  • fishing-resort-map on sw-lin-mesa: diff
  • fortune-street on sw-lin-mesa: diff
  • fortune-street-white-box on sw-lin-mesa: diff
  • f-zero-rain on sw-lin-mesa: diff
  • inverted-depth-range on sw-lin-mesa: diff
  • jd2-fmv on sw-lin-mesa: diff
  • kirby-shadows on sw-lin-mesa: diff
  • last-story-shadows on sw-lin-mesa: diff
  • lego-star-wars-crane-shadow on sw-lin-mesa: diff
  • luigi-shadows on sw-lin-mesa: diff
  • mario-baseball-shadows on sw-lin-mesa: diff
  • mario-sluggers-bar on sw-lin-mesa: diff
  • mario-tennis-menu on sw-lin-mesa: diff
  • medabots-crash on sw-lin-mesa: diff
  • megaman-heat on sw-lin-mesa: diff
  • melee-depth on sw-lin-mesa: diff
  • melee-lighting on sw-lin-mesa: diff
  • mii-channel on sw-lin-mesa: diff
  • milotic-texture on sw-lin-mesa: diff
  • mkdd-babypark on sw-lin-mesa: diff
  • mkdd-efb on sw-lin-mesa: diff
  • mkw-bridge on sw-lin-mesa: diff
  • mkwii-bluebox on sw-lin-mesa: diff
  • monkeyball-fuse on sw-lin-mesa: diff
  • mp3-bloom on sw-lin-mesa: diff
  • mp7-text on sw-lin-mesa: diff
  • mtennis-zfreeze on sw-lin-mesa: diff
  • my-word-coach on sw-lin-mesa: diff
  • nddemo-bumpmapping on sw-lin-mesa: diff
  • nddemo-lighting on sw-lin-mesa: diff
  • nfsu-purplerect on sw-lin-mesa: diff
  • nfsu-reflections on sw-lin-mesa: diff
  • nhl-slap on sw-lin-mesa: diff
  • pm-hc-jp on sw-lin-mesa: diff
  • rs3-bumpmapping on sw-lin-mesa: diff
  • rs3-skybox2 on sw-lin-mesa: diff
  • sadx-ui on sw-lin-mesa: diff
  • sfa-shadows on sw-lin-mesa: diff
  • sf-assault-flashing on sw-lin-mesa: diff
  • simpsons-game on sw-lin-mesa: diff
  • smb-mirror on sw-lin-mesa: diff
  • smg2-fog on sw-lin-mesa: diff
  • smg-marioeyes on sw-lin-mesa: diff
  • sms-bubbles on sw-lin-mesa: diff
  • sms-gc on sw-lin-mesa: diff
  • sms-water on sw-lin-mesa: diff
  • soa-black on sw-lin-mesa: diff
  • soniccolors-mm on sw-lin-mesa: diff
  • sonic-riders-blur on sw-lin-mesa: diff
  • sonicriderszg-gb on sw-lin-mesa: diff
  • spyro-bloom on sw-lin-mesa: diff
  • spyro-depth on sw-lin-mesa: diff
  • ssbm-pointsize on sw-lin-mesa: diff
  • super-sluggers-white-out on sw-lin-mesa: diff
  • sw3-dt on sw-lin-mesa: diff
  • thps4-shadow on sw-lin-mesa: diff
  • tos-invis-char on sw-lin-mesa: diff
  • tsp3-pinkgrass on sw-lin-mesa: diff
  • vegas-party-depth on sw-lin-mesa: diff
  • xenoblade-menu on sw-lin-mesa: diff
  • ztp-grass on sw-lin-mesa: diff
  • zww-armos on sw-lin-mesa: diff
  • zww-water on sw-lin-mesa: diff

automated-fifoci-reporter

@Pokechu22
Copy link
Contributor Author

As with last time, fishing-resort-map's map and ssbm-pointsize's reflection have been flipped. However, find-mii also works now! I tested, and it looks like both this change and #9424 were needed for it to render correctly. Other than that, the brightness changes that happened in the hardware renderer still didn't happen here, which is probably fine.

@leoetlino leoetlino merged commit 2f85b80 into dolphin-emu:master Feb 13, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants