Common/LinearDiskCache: Handle truncated shadercache files. #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Dec 19, 2020
AdmiralCurtiss
force-pushed
the
truncated-shadercache
branch
from
c1c3b51
to
f5170dc
Compare
smurf3tte
approved these changes
Dec 20, 2020
lioncash
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Without this you run into two issues:
value_sizebut before reading the actual value, the file position is not aligned on a boundary between values, so it would have no chance to find any newly written values the next time the cachefile is opened.I also took the opportunity to replace the manual new/delete with an unique_ptr.