Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit64: Fix FPURegCache::GetRegUtilization #9347

Merged
merged 1 commit into from Dec 21, 2020
Merged

Jit64: Fix FPURegCache::GetRegUtilization #9347

merged 1 commit into from Dec 21, 2020

Conversation

JosJuice
Copy link
Member

This performance bug was probably a simple copy-paste error. (The function was identical to GPRRegCache::GetRegUtilization.)

@JosJuice
Jit64: Fix FPURegCache::GetRegUtilization
9460467 
This performance bug was probably a simple copy-paste error.
(The function was identical to GPRRegCache::GetRegUtilization.)
degasus
degasus approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@degasus degasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this implementation is still as broken as fprInXmm is not updated correctly. However spilling based on gpr utilization is even worse...
However this is just a hint for which to register to spill, I'm fine with both ways.

@degasus degasus merged commit 1d489b3 into dolphin-emu:master Dec 21, 2020
10 checks passed
@JosJuice JosJuice deleted the fpr-utilization branch December 21, 2020 17:37
@JosJuice
Copy link
Member Author

JosJuice commented Feb 2, 2021

@degasus It took me until now to realize, but the existing fprInXmm logic does make sense: strncmp returns 0 when the strings match, not the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@degasus degasus degasus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @lioncash @degasus