Software: Invert backface test when viewport is positive #9350
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
force-pushed
the
sw-viewport
branch
from
ae89595
to
ff61dce
Compare
BhaaLseN
reviewed
Feb 13, 2021
Pokechu22
force-pushed
the
sw-viewport
branch
from
ff61dce
to
964bcf7
Compare
|
LGTM |
Fixes Jimmie Johnson's Anything with an Engine.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes Jimmie Johnson's Anything with an Engine, which is the only game that uses a positive viewport. This is the same issue that #5096 fixed in hardware, but the actual fix here is different; that one was achieved by mirroring vertices while this only needs to change the backface test; the image was already right-side up on the software renderer. I don't fully understand why.