Split OSREPORT logging type #9360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enumerated LOG_TYPE "OSREPORT" is currently used in both EXI_DeviceIPL.cpp and HLE_OS.cpp. In many games, the multitude of game functions detected by HLE_OS.cpp for OSREPORT logging results in poor log readability. This Pull Request remedies that by adding a new enumerated LOG_TYPE "OSREPORT_HLE" for log usage in HLE_OS.cpp. In the future, further changing how logging in HLE_OS.cpp works may be desirable. As it is, game functions are detected that send a single character to the log. This is a major source of poor readability.
|
IMO it might be better to create a new category for EXI_DeviceIPL and use that for everything that's logged there, rather than leaving OSREPORT for just the EXI logs. Though, that could make things a bit confusing if you specifically want the EXI OSReport logs. |
|
I left the original enumerated LOG_TYPE "OSREPORT" as is to minimally effect people's existing log configuration and existing code. In the GUI, however, the toggle is now named OSReport EXI. I'm not strongly opposed to changing it, these are just my thoughts. |
sepalani
approved these changes
Dec 26, 2020
There was a problem hiding this comment.
This PR LGTM.
Some remarks to keep in mind:
- The apploader requires an HLE OSReport, so the apploader messages will go through
OSReport HLE - This point is wrong (
that send a single character to the log) and just means you patched the wrong function which might be a signature false-positive, a stubbed function or the game literally sends one character at a time through the log
|
Yeah I think it makes more sense to keep EXI OSReport in OSREPORT... |
leoetlino
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The enumerated LOG_TYPE "OSREPORT" is currently used in both EXI_DeviceIPL.cpp and HLE_OS.cpp. In many games, the multitude of game functions detected by HLE_OS.cpp for OSREPORT logging results in poor log readability. This Pull Request remedies that by adding a new enumerated LOG_TYPE "OSREPORT_HLE" for log usage in HLE_OS.cpp.
In the future, further changing how logging in HLE_OS.cpp works may be desirable. As it is, game functions are detected that send a single character to the log. This is a major source of poor readability.