VideoCommon: Fix crash that occurs on loading a fifo log when Free Look is enabled #9362
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
During the Free Look refactor (#8867 ) I apparently forgot to test loading a fifo log. A crash occurs there because the camera control type is not set and therefore the controller is null.
This fixes the crash and adds some safety checks to check for null pointers.
Sorry about that!
EDIT: This crash is not specific to fifo per-se. It's just the fifo logs I tested had an initial frame of projection-type perspective where we call GetView(). Most games I tested startup with a projection type of orthographic, giving time for
Renderer::CheckForConfigChanges()to update the control type.