VideoCommon: allow Free Look to be manipulated by a quaternion #9366
+56
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
freelook_camera_quaternion
branch
2 times, most recently
from
cfc4629
to
c0d3ca7
Compare
iwubcode
force-pushed
the
freelook_camera_quaternion
branch
from
c0d3ca7
to
39bb6a7
Compare
jordan-woyak
reviewed
Jan 9, 2021
| @@ -56,6 +56,13 @@ Quaternion Quaternion::RotateZ(float rad) | |||
| return Rotate(rad, Vec3(0, 0, 1)); | |||
| } | |||
|
|
|||
| Quaternion Quaternion::RotateXYZ(const Vec3& rads) | |||
There was a problem hiding this comment.
There should maybe be a comment that explains this produces a quaternion of simultaneous rotations about the 3 axes. e.g. processing gyroscope input.
I don't know if I like the name RotateXYZ, but I don't know what a better name is either. :P
There was a problem hiding this comment.
Yeah, I'm horrible at naming things :D . Please let me know if you think of something better!
There was a problem hiding this comment.
Here are some suggestions "Rotate_all_axes" "3D_rotation" "Quaternion_rotation"
iwubcode
force-pushed
the
freelook_camera_quaternion
branch
from
39bb6a7
to
f77fc52
Compare
leoetlino
previously requested changes
Jan 27, 2021
iwubcode
force-pushed
the
freelook_camera_quaternion
branch
from
f77fc52
to
586c689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.