Android: Only have one settings entrypoint in game properties #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
changed the title
In 8c723d0, I intended to update the main activity, emulation activity and game properties dialog, but I forgot to actually update the game properties dialog. This commit fixes that. The changes outside of GamePropertiesDialog.java are just to hide the Wii controller settings for GameCube games.
JosJuice
force-pushed
the
android-game-properties-one-settings
branch
from
b0419a3
to
7cf62fe
Compare
lioncash
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In PR #9357, I intended to update the main activity, emulation activity and game properties dialog, but I forgot to actually update the game properties dialog. This commit fixes that.
The changes outside of GamePropertiesDialog.java are just to hide the Wii controller settings for GameCube games.