CMake: Update cmake_minimum_required calls using versions less than 2.8.12. #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that CMake 3.0.0 is over 6 years old at this point, is there any particular reason to not simply say "you need at least 3.0"? Limiting this to a maximum version just to get rid of a deprecation warning feels weird. |
|
….8.12. CMake warns support will be removed in a future version.
jordan-woyak
force-pushed
the
cmake-version-warnings
branch
from
0191d30
to
1699aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
My IDE was showing me CMake warnings and it was annoying.
"CMake Deprecation Warning at Externals/enet/CMakeLists.txt:1 (cmake_minimum_required):Compatibility with CMake < 2.8.12 will be removed from a future version of\nCMake.\n\nUpdate the VERSION argument value or use a ... suffix to tell\nCMake that the project does not need compatibility with older versions."
I've specified version 2.8.12 to eliminate the warnings.