Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JitArm64_Integer: Add optimizations for rlwimix #9373

Merged
merged 4 commits into from Jan 31, 2021
Merged

JitArm64_Integer: Add optimizations for rlwimix #9373

merged 4 commits into from Jan 31, 2021
+38 −17

Conversation

merryhime
Copy link
Contributor

  • Check for case when source field is at LSB
  • Use BFXIL if possible
  • Avoid ROR where possible

degasus
degasus reviewed Jan 27, 2021
View reviewed changes
Source/Core/Common/Arm64Emitter.cpp Outdated
void ARM64XEmitter::BFXIL(ARM64Reg Rd, ARM64Reg Rn, u32 lsb, u32 width)
{
u32 size = Is64Bit(Rn) ? 64 : 32;
ASSERT_MSG(DYNA_REC, (lsb + width) <= size,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& lsb + width >= 1

@merryhime merryhime marked this pull request as ready for review January 31, 2021 11:52
@merryhime
Copy link
Contributor Author

Changed assertions to match those in manual for easier verification.

@degasus degasus merged commit 27b7e58 into dolphin-emu:master Jan 31, 2021
10 checks passed
@merryhime merryhime deleted the arm64-rlwimix branch January 31, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degasus degasus degasus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@merryhime @degasus @MerryMage