Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latency field being initially enabled on audio backends not supporting it #9379

Merged
merged 1 commit into from Dec 29, 2020

Conversation

Pokechu22
Copy link
Contributor

On platforms where there is at least one audio backend supporting latency (e.g. Windows), the latency field was enabled on all backends, even if they don't support it, though it would become disabled after changing the backend. This also happened after emulation is stopped. The cause was OnEmulationStateChanged not checking if the backend supported latency; OnEmulationStateChanged is called when the audio pane is first constructed.

@Filoppi
Copy link
Contributor

Filoppi commented Dec 29, 2020

True. There were quite a lot of bugs like that in the AudioPane, all I could found have been fixed here (including this), https://github.com/Filoppi/dolphin/blob/audio-input-fixes/Source/Core/DolphinQt/Settings/AudioPane.cpp, still being worked on. But this fix is nice to have now.

@leoetlino leoetlino merged commit 15d4ddf into dolphin-emu:master Dec 29, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants